PR a repositorio base para corrección - grupo 2

.github/labeler.yml

@@ -0,0 +1,33 @@
+readme:
+  - src/README.md
+  - README.md
+
+feature:
+  - src/app/**/*
+
+tests:
+  - src/tests/**/*
+
+good practices:
+  - git-hooks/**/*
+  - .github/workflows/**/*
+
+automation:
+  - git-hooks/**/*
+  - .github/workflows/**/*
+
+code quality:
+  - git-hooks/**/*
+  - .github/workflows/**/*
+
+composer:
+  - src/composer.json
+  - composer.json
+
+database:
+  - src/database/**/*
+
+docker:
+  -docker/docker
+  -Dockerfile
+  -docker-compose.yml

.github/workflows/label.yml

@@ -0,0 +1,19 @@
+# This workflow will triage pull requests and apply a label based on the
+# paths that are modified in the pull request.
+#
+# To use this workflow, you will need to set up a .github/labeler.yml
+# file with configuration.  For more information, see:
+# https://github.com/actions/labeler
+
+name: Labeler
+on: [pull_request]
+
+jobs:
+  label:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/labeler@v2
+      with:
+        repo-token: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/validation.yml

@@ -0,0 +1,53 @@
+name: Laravel Validation
+on:
+  push:
+  pull_request:
+    branches:
+      - develop
+
+jobs:
+  validation:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup
+        run: |
+          docker-compose up -d
+          docker ps
+      - name: Build
+        run: |
+          docker exec -i laravel-php sh
+          cd src
+          composer install
+          cp .env.example .env
+          php artisan package:discover
+          php artisan key:generate
+      #- name: Database migation
+      #  run: |
+      #    docker exec -i laravel-php sh
+      #    cd src
+      #    php artisan migrate
+      #- name: Database migation
+      #  run: |
+      #    docker exec -i laravel-php sh
+      #    cd src
+      #    php artisan db:seed
+      - name: Linter
+        run: |
+          docker exec -i laravel-php sh
+          cd src
+          ./vendor/bin/phpcs -n app/*
+          ./vendor/bin/phpcs -n bootstrap/app.php
+          ./vendor/bin/phpcs -n config/*
+          ./vendor/bin/phpcs -n database/*
+          ./vendor/bin/phpcs -n postman/*
+          ./vendor/bin/phpcs -n public/*
+          ./vendor/bin/phpcs -n resources/*
+          ./vendor/bin/phpcs -n routes/*
+          ./vendor/bin/phpcs -n tests/*
+      - name: Test
+        run: |
+          docker exec -i laravel-php sh
+          cd src
+          ./vendor/bin/phpunit

.gitignore

@@ -21,5 +21,10 @@ bundles/
 .hg/
 .git/
 vendor/pkg/
+vendor
 pyenv
-Vagrantfile
+Vagrantfile 
+mysql/ib*
+*.cache
+mysql/laravel/*.frm
+mysql/laravel/*.ibd

540-example/app/datasource/database/EloquentUser540DataSource.php

@@ -0,0 +1,18 @@
+<?php
+
+namespace App\DataSource\Database;
+
+use App\Models\User;
+use Exception;
+
+class EloquentUser540DataSource
+{
+    public function findByEmail($email): User
+    {
+        $user = User::query()->where('email', $email)->first();
+        if (is_null($user)) {
+            throw new Exception('User not found');
+        }
+        return $user;
+    }
+}

src/app/Http/Controllers/IsEarlyAdopterUserController.php → 540-example/app/http/controllers/IsEarlyAdopterUserController.php

@@ -24,7 +24,6 @@ public function __invoke(string $email): JsonResponse
     {
         try {
             $isEarlyAdopter = $this->isEarlyAdopterService->execute($email);
-
         } catch (Exception $exception) {
             return response()->json([
                 'error' => $exception->getMessage()

540-example/app/models/User540.php

@@ -0,0 +1,16 @@
+<?php
+
+namespace App\Models;
+
+use Illuminate\Contracts\Auth\MustVerifyEmail;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
+use Illuminate\Database\Eloquent\Model;
+use Illuminate\Foundation\Auth\User as Authenticatable;
+use Illuminate\Notifications\Notifiable;
+
+class User540 extends Model
+{
+    use HasFactory;
+
+    protected $fillable = ['id', 'name', 'email'];
+}

src/app/Services/EarlyAdopter/IsEarlyAdopterService.php → 540-example/app/services/EarlyAdopter/IsEarlyAdopterService.php

@@ -2,21 +2,21 @@
 
 namespace App\Services\EarlyAdopter;
 
-use App\DataSource\Database\EloquentUserDataSource;
+use App\DataSource\Database\EloquentUser540DataSource;
 use Exception;
 
 class IsEarlyAdopterService
 {
     /**
-     * @var EloquentUserDataSource
+     * @var EloquentUser540DataSource
      */
     private $eloquentUserDataSource;
 
     /**
      * IsEarlyAdopterService constructor.
-     * @param EloquentUserDataSource $eloquentUserDataSource
+     * @param EloquentUser540DataSource $eloquentUserDataSource
      */
-    public function __construct(EloquentUserDataSource $eloquentUserDataSource)
+    public function __construct(EloquentUser540DataSource $eloquentUserDataSource)
     {
         $this->eloquentUserDataSource = $eloquentUserDataSource;
     }

540-example/database/factories/User540Factory.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Database\Factories;
+
+use App\Models\User540;
+use Illuminate\Database\Eloquent\Factories\Factory;
+
+class User540Factory extends Factory
+{
+    /**
+     * The name of the factory's corresponding model.
+     *
+     * @var string
+     */
+    protected $model = User::class;
+
+    /**
+     * Define the model's default state.
+     *
+     * @return array
+     */
+    public function definition()
+    {
+        return [
+            'id' => 1,
+            'name' => 'user_name',
+            'email' => 'email@email.com'
+        ];
+    }
+}

src/tests/Integration/Controller/IsEarlyAdopterUserControllerTest.php → 540-example/tests/integration/controller/IsEarlyAdopterUserControllerTest.php

@@ -2,7 +2,7 @@
 
 namespace Tests\Integration\Controller;
 
-use App\Models\User;
+use App\Models\User540;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Http\Response;
 use Tests\TestCase;
@@ -16,7 +16,7 @@ class IsEarlyAdopterUserControllerTest extends TestCase
      */
     public function noUserFoundForGivenEmail()
     {
-        User::factory(User::class)->create();
+        User540::factory(User540::class)->create();
 
         $response = $this->get('/api/user/another@email.com');
 
@@ -28,7 +28,7 @@ public function noUserFoundForGivenEmail()
      */
     public function userIsEarlyAdopter()
     {
-        User::factory(User::class)->create();
+        User540::factory(User540::class)->create();
 
         $response = $this->get('/api/user/email@email.com');
 

540-example/tests/integration/datasources/EloquentUserDataSourceTest.php

@@ -0,0 +1,54 @@
+<?php
+
+namespace Tests\Integration\DataSources;
+
+use App\DataSource\Database\EloquentUser540DataSource;
+use App\Models\User540;
+use Exception;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Tests\TestCase;
+
+class EloquentUserDataSourceTest extends TestCase
+{
+    use RefreshDatabase;
+
+    /**
+     * @test
+     */
+    public function findsUserByEmail()
+    {
+        User540::factory(User540::class)->create();
+        $eloquentUserDataSource = new EloquentUser540DataSource();
+
+        $user = $eloquentUserDataSource->findByEmail('email@email.com');
+
+        $this->assertInstanceOf(User::class, $user);
+    }
+
+    /**
+     * @test
+     */
+    public function noUserIsFoundForTheGivenEmailI()
+    {
+        $eloquentUserDataSource = new EloquentUser540DataSource();
+
+        $this->expectException(Exception::class);
+
+        $eloquentUserDataSource->findByEmail('email@email.com');
+    }
+
+    /**
+     * @test
+     */
+    public function noUserIsFoundForTheGivenEmailII()
+    {
+        User540::factory(User540::class)->create();
+        $eloquentUserDataSource = new EloquentUser540DataSource();
+
+        try {
+            $eloquentUserDataSource->findByEmail('not_known@email.com');
+        } catch (Exception $exception) {
+            $this->assertEquals('User not found', $exception->getMessage());
+        }
+    }
+}

src/tests/Unit/Services/EarlyAdopter/IsEarlyAdopterServiceTest.php → 540-example/tests/unit/EarlyAdopter/IsEarlyAdopterServiceTest.php

@@ -2,16 +2,16 @@
 
 namespace Tests\Unit\Services\EarlyAdopter;
 
-use App\DataSource\Database\EloquentUserDataSource;
-use App\Models\User;
+use App\DataSource\Database\EloquentUser540DataSource;
+use App\Models\User540;
 use App\Services\EarlyAdopter\IsEarlyAdopterService;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Prophet;
 
 class IsEarlyAdopterServiceTest extends TestCase
 {
     /**
-     * @var EloquentUserDataSource
+     * @var EloquentUser540DataSource
      */
     private $eloquentUserDataSource;
 
@@ -27,7 +27,7 @@ protected function setUp(): void
     {
         parent::setUp();
         $prophet = new Prophet();
-        $this->eloquentUserDataSource = $prophet->prophesize(EloquentUserDataSource::class);
+        $this->eloquentUserDataSource = $prophet->prophesize(EloquentUser540DataSource::class);
 
         $this->isEarlyAdopterService = new IsEarlyAdopterService($this->eloquentUserDataSource->reveal());
     }
@@ -38,7 +38,7 @@ protected function setUp(): void
     public function userIsNotEarlyAdopter()
     {
         $email = 'not_early_adopter@email.com';
-        $user = new User();
+        $user = new User540();
         $user->fill(['id' => 9999, 'email' => $email]);
 
         $this->eloquentUserDataSource->findByEmail($email)->shouldBeCalledOnce()->willReturn($user);
@@ -54,7 +54,7 @@ public function userIsNotEarlyAdopter()
     public function userIsAnEarlyAdopter()
     {
         $email = 'not_early_adopter@email.com';
-        $user = new User();
+        $user = new User540();
         $user->fill(['id' => 1, 'email' => $email]);
 
         $this->eloquentUserDataSource->findByEmail($email)->shouldBeCalledOnce()->willReturn($user);