Skip to content

Conversation

@spantaleev
Copy link
Contributor

Fixes #363

@64bit
Copy link
Owner

64bit commented Jun 1, 2025

Thank you for the PR!

This can be improved to match the spec image string or array Required
https://github.com/openai/openai-openapi/blob/master/openapi.yaml#L21129-L21137

That's because a user can input a single or multiple images in builder like:

single image

  CreateImageEditRequestArgs::default()
     .image(single_image)
     ...
    .build()?

multiple image

  CreateImageEditRequestArgs::default()
     .image([image1, image2])  # this can be vector, or just [] 
     ...
    .build()?

There are pattern in the repo which makes it happen in other places, and then implement From traits to have API like above.

Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous comment is good to have - can be added later.

Thank you for the PR!

@64bit 64bit merged commit 08cae25 into 64bit:main Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CreateImageEditRequest only deals with a single image

2 participants