Skip to content

fix: prevent SSRF in fetch upload by blocking private/internal IPs #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tranquac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent SSRF in fetch upload by blocking private/internal IPs #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/org/b3log/solo/processor/FetchUploadProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,19 @@ public void fetchUpload(final RequestContext context) {
return;
}

// SSRF protection: block requests to private/internal IPs
try {
final java.net.URL parsedUrl = new java.net.URL(originalURL);
final java.net.InetAddress address = java.net.InetAddress.getByName(parsedUrl.getHost());
if (address.isLoopbackAddress() || address.isSiteLocalAddress() || address.isLinkLocalAddress()) {
LOGGER.log(Level.WARN, "Blocked SSRF attempt to private IP: " + originalURL);
return;
}
} catch (final Exception e) {
LOGGER.log(Level.WARN, "Failed to resolve URL host: " + originalURL);
return;
}

if (Images.uploaded(originalURL)) {
return;
}
Expand Down