Don't load DFS by default #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFS was an add-on to the original hardware and isn't really useful with the bot. Loading it by default raises PAGE by 2816 bytes. Even in the best case of MODE7 and rocket mode, that's a 10% reduction in the available RAM to BBC BASIC. In MODE2 and with the GXR loaded it's a whopping 35% reduction. Support enabling DFS via an emoji, which is probably only really useful as a way to allow easily running programs written for older versions of the bot which assume the value of PAGE or the screen contents.
|
Make sense. The only thing that concerns me is there are tweets with Owlet links out there that may break if we change the DFS default. How about we give Owlet different default DFS behavior based on data URL version : We make a We make a I started down this path with my URL shortener which is now live Line 74 in d0467a3 |
|
Good point, and the solution you suggest makes sense. A new window really needs to default to v3 so that people writing new programs get something that matches the live bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DFS was an add-on to the original hardware and isn't really useful with the bot. Loading it by default raises PAGE by 2816 bytes. Even in the best case of MODE7 and rocket mode, that's a 10% reduction in the available RAM to BBC BASIC. In MODE2 and with the GXR loaded it's a whopping 35% reduction.
Support enabling DFS via an emoji, which is probably only really useful as a way to allow easily running programs written for older versions of the bot which assume the value of PAGE or the screen contents.
Owlet ideally needs updating to match - happy to do that too.