Feat/wire login logout profile#23
Merged
Merged
Conversation
… login, add logout form to base template
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the login, logout, and profile flow so authentication routes consistently lead users into the dashboard as the post-login product surface.
Changes
templates/users/login.html.templates/users/signup.html.templates/registration/login.htmlandtemplates/registration/signup.html.Behavior
dashboard:index.dashboard:index.next.Why
The dashboard is becoming the authenticated product surface, so authentication entry points need predictable routing, redirects, and navigation before deeper product features are added.
Validation
docker compose exec -T web python manage.py check --settings=config.settings.localdocker compose exec -T web python -m black . --checkdocker compose exec -T web python -m ruff check .docker compose exec -T web pytest apps/users/tests/test_auth_views.py tests/test_views.py -qResult
All checks passed. Auth/routing tests:
18 passed.Notes
Obsolete Django default registration templates were removed to avoid future confusion now that auth templates live under
templates/users/.