Conversation
|
I did think about whether they should be separate or a single PR. I came to the conclusion that they should be separate because the model page in #1056 can be merged independently of the Rose/Cylc docs, while this shouldn't be merged before the Rose/Cylc docs are finalised. |
|
I understand and that's true. I think the Rose/Cylc page will be ready before we're ready for AM3 release (i.d., before we're ready to merge these pages), so I would not see that a a problem. |
|
|
Ok, I'll merge this branch with the one from #1056 and close the other PR |
ccarouge
left a comment
There was a problem hiding this comment.
A few comments, nothing major.
|
@atteggiani Just need your review before merging |
|
Getting on it. |
|
@Whyborn We don't merge for alpha! We only merge at the beta release! |
|
@ccarouge Oh we don't? So we just keep any links pointing at the PR preview until beta? |
|
@Whyborn yes. |
254ca6a to
963790e
Compare
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
…ESS-Hive-Docs into 1039-AM3-run-a-model-docs
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
Co-authored-by: Davide Marchegiani <davide.marchegiani@anu.edu.au>
atteggiani
left a comment
There was a problem hiding this comment.
Thank you @Whyborn for addressing my comments.
The updates look all pretty good!
Note there are still some files that show here when they should not be within the changed filetree. Also the indentation changes in the mkdocs.yml still seems to be there.
Apart from these minor issues, this PR is ready to be merged.
There was a problem hiding this comment.
This is still showing up.
There was a problem hiding this comment.
This is still showing up.
|
@atteggiani I don't see any of the whitespace changes on the |
atteggiani
left a comment
There was a problem hiding this comment.
Everything looks good now.
Thank you @Whyborn
|
I will mark this as draft as this is an Alpha Release and this PR should not be merged yet. |
ACCESS-Hive Docs
Description
Adds a bare-minimum page that, in combination with the in-progress Rose/Cylc docs, describes briefly how to run AM3.
Type of change
Checklist: