Note on setting spack packages version#1157
Conversation
|
I made a new PR to replace #1064 - thoughts @aidanheerdegen @harshula ? |
aidanheerdegen
left a comment
There was a problem hiding this comment.
Thanks.
Small typo. Seems fine otherwise, but note that what is written it is pretty much immediately obsolete with spack 1.1.
Why is that ? - i ran the same command on spack 1.1, it worked fine |
|
spack 1.1 checks it out from a branch: rather than the user manually checking out access-spack-packages but spack 1.1 doesn't set the spack packages version for the user |
Ah right. Well the documentation says the options is |
Good point. I was wrong. And with the change @harshula made to expose So I'll approve, but should get Harshula's opinion. |
Oh yes - this part is fine. Ill apply it |
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
|
This PR should wait for PR #1154 to be merged. |
|
Thanks Harshula - will mark as draft until #1154 |
|
Thanks @harshula - ready for review |
|
@ACCESS-NRI/hivedocsteam - ready for final review |
Is this still relevant? |
atteggiani
left a comment
There was a problem hiding this comment.
Changes look good to me.
|
Could you merge please @atteggiani |
|
Please ensure these commits are squashed ... |
Closes #987
This adds a step to spack develop instructions to set the access-spack-packages version based on the most recent model release.