Bare documentation infrastructure#131
Conversation
|
I agree we shouldn't go with both. |
|
We've got a build from the PR! (see the "More Details" from the action). https://cmip7-input--131.org.readthedocs.build/en/131/ I think we are good to merge. |
|
@atteggiani I've used the GitHub OAuth app for RTD because I'm not setup with the new GitHub App. So might need to migrate, soz. |
|
@penguian not sure what to do about the failure of the pre-commit-check. |
No problem. Did you use your RTD account or access-bot to set this up? |
Mine, but access-bot is a full maintainer. Actually, I forgot to give repository permissions to access-bot. So it is a maintainer, but it might not have the perms it needs to be fully functional. |
|
Sounds good, thank you!
Once the RTD project is setup, GitHub repo admin permissions are not needed to still be able to manage the RTD project. |
|
@atteggiani Do you know why the pre-commit checks are failing? |
penguian
left a comment
There was a problem hiding this comment.
Checks are failing. Does this need to be fixed before approval?
|
@penguian The check-links failure might be because there are no build of the CMIP7-Input documentation yet (since we are putting the infrastructure together). There are preview builds but no "release" build. For the pre-commit, I'm not sure which error it can't fix by itself. See the list here: https://github.com/ACCESS-NRI/CMIP7-Input/actions/runs/26386875899/job/77667255315?pr=131#step:4:158. It says it found 2 errors, 1 fixed and 1 remaining. But it does not say which one is fixed, and as far as I can tell, there are 3 failed, not 2... So if anyone knows how to read the report that would be useful. One thing we likely can't fix is: |
|
Yes, as Claire mentioned, the pre-commit checks should probably not include the The line too long error can be easily fixed by returning with a newline earlier in that line. Also I am not sure which error was fixed and which not, but updating the |
Adds the bare infrastructure for the documentation based off the configs doc infrastructure.
This builds locally. @atteggiani Should we look at using GitHub pages or readthedocs for this one? The decision to go with one or the other hasn't been made but we may have some idea of where it is likely to get. We probably don't need to setup both now, just choose one. Information for RTD is in this PR.