Skip to content

WOMBAT-lite documentation#80

Merged
dougiesquire merged 3 commits intomainfrom
pearseb-patch-1
Feb 26, 2026
Merged

WOMBAT-lite documentation#80
dougiesquire merged 3 commits intomainfrom
pearseb-patch-1

Conversation

@pearseb
Copy link
Copy Markdown
Collaborator

@pearseb pearseb commented Jan 13, 2026

Initial draft of docs

@pearseb pearseb requested a review from dougiesquire January 13, 2026 05:36
@pearseb pearseb self-assigned this Jan 13, 2026
Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is terrific @pearseb - really well done.

The references to the variable names are very helpful. There are a few instances where they are missing and others where they are missing. I've suggested adding a few, but probably missed some.

@pearseb
Copy link
Copy Markdown
Collaborator Author

pearseb commented Feb 12, 2026

Thanks Dougie will make those corrections now and will recommit.

@pearseb
Copy link
Copy Markdown
Collaborator Author

pearseb commented Feb 24, 2026

I've made some major additions and clean-up to the WOMBAT-lite documentation. These include:

  • more consistent labelling of units and "in-code" variable names
  • more literature citations and justifications of the equations
  • the addition of a "update_from_bottom" page to describe for the permanent burial of detritus and calcium carbonate

@dougiesquire dougiesquire force-pushed the pearseb-patch-1 branch 6 times, most recently from c04d393 to 342a0d4 Compare February 26, 2026 09:59
@dougiesquire
Copy link
Copy Markdown
Collaborator

I've now included the commits from #91 as we discussed.

I'll now interactively rebase this into three commits:

  • One for the WOMBATlite code changes
  • One for the WOMBATlite docs
  • One for the WOMBATmid bug fix

pearseb and others added 3 commits February 26, 2026 21:52
* aesthetic changes to some diagnostics and code comments
* zooplankton now explicitly dissolve sinking CaCO3 in their guts when consuming particulates
* Fe chemistry now includes varying colloidal fraction and a light-dependent stability constant
* phytoplankton uptake of iron now reduced under light limitation but not to the same extent as C uptake
* zooplankton egestion, excretion and assimilation of C and Fe following Le Mezo & Galbraith 2021
* zooplankton prey items now normalized to dietary fractions (Gentleman et al., 2003)

Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
Co-authored-by: Dougie Squire <dougie.squire@anu.edu.au>
@dougiesquire
Copy link
Copy Markdown
Collaborator

I've also removed the now-unused fcolloid parameter and made some formatting changes for fortitude. I've squashed these into the "WOMBATlite: major update including:" commit

@dougiesquire dougiesquire marked this pull request as ready for review February 26, 2026 10:53
@dougiesquire dougiesquire merged commit 5c499d1 into main Feb 26, 2026
9 checks passed
@dougiesquire dougiesquire deleted the pearseb-patch-1 branch February 26, 2026 11:13
dougiesquire added a commit that referenced this pull request Feb 26, 2026
@dougiesquire
Copy link
Copy Markdown
Collaborator

dougiesquire commented Feb 26, 2026

  • One for the WOMBATmid bug fix

I ended up dropping this commit (6314aef) because it was declaring a variable this isn't actually used yet.

I think this commit was supposed to go into the wombatmid-NOSC branch so I've added it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants