WOMBATlite: Treat key biological loss terms semi-implicitly#97
Merged
dougiesquire merged 3 commits intomainfrom Mar 25, 2026
Merged
WOMBATlite: Treat key biological loss terms semi-implicitly#97dougiesquire merged 3 commits intomainfrom
dougiesquire merged 3 commits intomainfrom
Conversation
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
pearseb
reviewed
Mar 25, 2026
dougiesquire
force-pushed
the
semi-implicit-loss
branch
from
6ca6e50 to
a443314
Compare
Co-authored-by: Pearse J Buchanan <[email protected]>
Collaborator
Author
pearseb
approved these changes
Mar 25, 2026
Collaborator
|
Nice :) Great contribution Dougie. ACCESS-OM2-0.1º-WOMBATlite here we come. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes described in #96
To summarise, there are a few loss terms in the biological tendency equations that are particularly susceptible to instability with Forward Euler time-stepping:
phymorq = f(phy^2)zoomorq = f(zoo^2)detremi = f(det^2)caldiss = f(caco3),aradiss = f(caco3),pocdiss = f(caco3),zoodiss = f(caco3)This PR rewrites these update equations using a semi-implicit scheme for these terms.
Note, I haven't looked at WOMBATmid, but this presumably has similar issues.