-
Notifications
You must be signed in to change notification settings - Fork 1
402 access oasis mct #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
402 access oasis mct #429
Conversation
79f2068 to
9621440
Compare
|
!test repro |
|
✅ The Bitwise Reproducibility Check Succeeded ✅ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/13cc7d229b0d4bda193879b8b30cde3441d61bec/testing/checksum Test summary: |
|
!test repro |
|
When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/13cc7d229b0d4bda193879b8b30cde3441d61bec/testing/checksum Test summary: |
|
@aidanheerdegen, @manodeep, @MartinDix I've cherry picked the changes to the namcouple for the new version of oasis from @manodeep's branch final-opt-devPI. These conflicted with @MartinDix's earlier changes to reduce the amount of oasis logging in #314. The configuration runs ok, however does produce the extra output described in #314: debug.root.03: I've tried to reapply these logging changes in 16ac67b, however it's resulting in a crash from oasis: work/atmosphere/nout.000000 I haven't figured out what's going on yet |
|
It wasn't clear to me that @MartinDix's changes could be naively applied, as it looked like a significant change in format. @manodeep would know more as he made the changes. |
|
I am taking a look now @blimlim Are you happy for me to push to this branch if I have any code/namelist updates? |
|
The The biggest change to the |
Yeah definitely happy for you to push to this branch! Had you worked out a final version of the namcouple file to use? I'm just testing out if I can get @MartinDix's earlier changes to still work. |
|
!test repro |
|
When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/13cc7d229b0d4bda193879b8b30cde3441d61bec/testing/checksum Test summary: |
|
Huh! Okay - then I am going to overwrite with the working version from here |
|
!test repro |
|
The previous namcouple still had a couple of places with the "4" and CHECKIN/CHECKOUT - maybe that was causing the bit repro test issue. The file now contains the raw contents from the previously working namcouple file (independent fields though, rather than multi-fields) |
|
✅ The Bitwise Reproducibility Check Succeeded ✅ When comparing:
Further informationThe experiment can be found on Gadi at The checksums generated by this The checksums compared against are found here https://github.com/ACCESS-NRI/access-esm1.6-configs/tree/13cc7d229b0d4bda193879b8b30cde3441d61bec/testing/checksum Test summary: |
|
2 simultaneous month sanity check confirms no issues after restarting: The extra diagnostic information mentioned here is also no longer included in the logs, as desired! |
aidanheerdegen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not looked at the namcouple file, not my area of expertise, but assume @blimlim and @manodeep have that covered.
I have checked the component spack hashes against the model release DB and they match (should make that an automatic check ....).
|
!cherry-pick c7e3cd1 into dev-preindustrial+emissions |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-preindustrial+emissions was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into dev-flat10 |
|
!cherry-pick c7e3cd1 into dev-1pctCO2-bgc |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-flat10 was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into dev-1pctCO2-rad |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-1pctCO2-bgc was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into dev-1pctCO2 |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-1pctCO2-rad was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into dev-4xCO2+concentrations |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-1pctCO2 was successful. The new pull request can be reviewed and approved here. |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-4xCO2+concentrations was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into dev-4xCO2+concentrations |
Automatic cherry-pick failed. It seems there are previous unfinished attempts to cherry-pick commits from this PR to the following branch(es): If the current cherry-pick attempt is for a different set of commits, make sure that the previous attempts are fully merged and that the corresponding branches have been deleted. |
|
!cherry-pick c7e3cd1 into dev-historical+concentrations |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into dev-historical+concentrations was successful. The new pull request can be reviewed and approved here. |
|
!cherry-pick c7e3cd1 into test-historical+emissions |
|
Automatic Git cherry-picking of commit(s) c7e3cd1 into test-historical+emissions was successful. The new pull request can be reviewed and approved here. |
1. Summary:
This PR updates to the latest 2026.01.000 deployment. This uses the ACCESS-NRI fork of oasis-mct, and includes a CICE update which fixes a small problem in the flux diagnostics.
Upgrading to Oasis3-mct v5.2 requires changes to the coupler's namcouple file. These have been cherry-picked from #298.
2. Issues Addressed:
3. Dependencies (e.g. on payu, or model)
This change requires changes to (note pull request(s) where relevant):
4. Ad-hoc Testing
What ad-hoc testing was done? How are you convinced this change is correct (plots are good)?
5. CI Testing
!test reprohas been run6. Reproducibility
Is this reproducible with the previous commit? (If not, why not?)
!test repro commithas been run.7. Performance
Has the model performance (say, throughput of model-years/wall-day) changed?
If yes, provide the numbers from your testing. Is the performance better or worse?
8. Manifests
Have you changed the executable, the input files and/or the restart files?
If yes, have you updated the manifests?
To update the manifests, run payu setup (in a cloned copy of your feature branch) with reproducibility tests turned off:
Then commit the newly created manifest files (under manifests/) only to the branch for this PR.
9. Documentation
Is the documentation updated?
10. Merge Strategy