Skip to content

Add rigorous build option with exclusions for known problems #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MartinDix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rigorous build option with exclusions for known problems #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions packages/um7/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class Um7(Package):
depends_on("[email protected]", type=("build", "link"))

variant("optim", default="high", description="Optimization level",
values=("high", "debug"), multi=False)
values=("high", "debug", "rigorous"), multi=False)

phases = ["edit", "build", "install"]

Expand Down Expand Up @@ -68,6 +68,8 @@ def _exe_name(self, optim_value):
"""
if optim_value == "debug":
return "um_hg3_dbg.exe"
elif optim_value == "rigorous":
return "um_hg3_rigorous.exe"
else:
return "um_hg3.exe"

Expand Down Expand Up @@ -118,13 +120,29 @@ def edit(self, spec, prefix):
if opt_value == "debug":
FO = "-O0"
FTRACEBACK = "-traceback"
CDEBUG = "-debug all"
FDEBUG = "-debug all"
FG = "-g"
FARCH = ""
FOBLANK = "-O0"
elif opt_value == "rigorous":
FO = "-O0"
FTRACEBACK = "-traceback"
CDEBUG = "-debug all"
FDEBUG = "-fp-model strict -check all -check noarg_temp_created -init=snan -init=array -init=huge"
# Exclude bounds checking
FDEBUG_XB = "-fp-model strict -check all -check nobounds -check noarg_temp_created -init=snan -init=array -init=huge"
# Exclude pointer checking (also unallocated arrays)
FDEBUG_XP = "-fp-model strict -check all -check nopointers -check noarg_temp_created -init=snan -init=array -init=huge"
# Exclude both
FDEBUG_X = "-fp-model strict -check all -check nobounds -check nopointers -check noarg_temp_created -init=snan -init=array -init=huge"
FG = "-g"
FARCH = ""
FOBLANK = "-O0"
else:
FO = "-O2"
FTRACEBACK = ""
CDEBUG = ""
FDEBUG = ""
FG = ""
FARCH = "-xCORE-AVX512"
Expand Down Expand Up @@ -168,7 +186,7 @@ def edit(self, spec, prefix):
target {EXE_NAME}
tool::ar ar
tool::cc mpicc
tool::cflags {FO} -g {FTRACEBACK} {FDEBUG} {FARCH} -fp-model precise
tool::cflags {FO} -g {FTRACEBACK} {CDEBUG} {FARCH} -fp-model precise
tool::cpp cpp
tool::cppflags
tool::cppkeys {CPPKEYS}
Expand All @@ -186,10 +204,27 @@ def edit(self, spec, prefix):

tool::geninterface none
tool::ld mpif90
tool::ldflags {FOBLANK} -g -traceback {FDEBUG} -static-intel {libs}
tool::ldflags {FOBLANK} -g -traceback {CDEBUG} -static-intel {libs}
"""

if opt_value == "rigorous":
# Exclude checking for some known issues. See https://github.com/ACCESS-NRI/UM7/issues/37
rigorous_exclusions = f"""
tool::fflags::control::top_level::atm_step {FO} -g -traceback {FDEBUG_X} -i8 -r8 {FFLAGS}
tool::fflags::control::top_level::setcona_ctl {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
tool::fflags::control::top_level::glue_rad-rad_ctl2 {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
tool::fflags::control::top_level::ni_conv_ctl {FO} -g -traceback {FDEBUG_XP} -i8 -r8 {FFLAGS}
tool::fflags::control::top_level::ni_gwd_ctl {FO} -g -traceback {FDEBUG_XP} -i8 -r8 {FFLAGS}
tool::fflags::atmosphere::dynamics_advection::tri_linear {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
tool::fflags::atmosphere::dynamics_advection::ecmwf_quasi_cubic {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
tool::fflags::atmosphere::dynamics_advection::h_quasi_cubic_v_quintic {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
tool::fflags::atmosphere::dynamics_advection::update_rho {FO} -g -traceback {FDEBUG_XB} -i8 -r8 {FFLAGS}
"""

with open(self._bld_cfg_path, "w") as bld_cfg_file:
bld_cfg_file.write(config)
if opt_value == "rigorous":
bld_cfg_file.write(rigorous_exclusions)


def build(self, spec, prefix):
Expand All @@ -210,4 +245,3 @@ def install(self, spec, prefix):
install(
join_path(self._bld_path, "bin", um_exe),
join_path(prefix.bin, um_exe))