Add default CICE5 builds when using CMake#383
Merged
anton-seaice merged 5 commits intoapi-v2from Feb 18, 2026
Merged
Conversation
anton-seaice
changed the title
anton-seaice
commented
Feb 11, 2026
anton-seaice
commented
Feb 11, 2026
anton-seaice
commented
Feb 11, 2026
anton-seaice
commented
Feb 11, 2026
harshula
reviewed
Feb 11, 2026
anton-seaice
changed the title
anton-seaice
requested review from
aidanheerdegen,
dougiesquire and
harshula
Split into seperate cmake, build and install steps
dougiesquire
approved these changes
Feb 17, 2026
Contributor
dougiesquire
left a comment
dougiesquire
left a comment
There was a problem hiding this comment.
LGTM @anton-seaice. One nothing suggestion to prove I looked
Contributor
Author
|
Ready for final reviews See ACCESS-NRI/ACCESS-OM2#135 for builds on gadi and links to repro tests with the OM2 |
dougiesquire
approved these changes
Feb 18, 2026
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
harshula
reviewed
Feb 18, 2026
Comment on lines
+179
to
+182
| if all([ | ||
| self.spec.variants[variant].value != 'none' | ||
| for variant in layout_variants | ||
| ]): |
Collaborator
There was a problem hiding this comment.
It would be clearer that this is a list comprehension if the square brackets are immediately at the start and end of the list comprehension.
harshula
reviewed
Feb 18, 2026
Comment on lines
+186
to
+189
| elif all([ | ||
| self.spec.variants[variant].value == 'none' | ||
| for variant in layout_variants | ||
| ]): |
Collaborator
There was a problem hiding this comment.
It would be clearer that this is a list comprehension if the square brackets are immediately at the start and end of the list comprehension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for doing multiple CMake builds within a spack package.
For model releases & deployments, we use the defaults in this package. For OM2 this produces three executables.
For development, optimisation work etc, the user can specify the grid & processor layout, but only one executable per spack spec.
All current behaviour is unmodified, except that setting
build_system=cmakewithout providing the layout variants is now supported, and builds the default layouts.In the unlikely case we changed the default build layouts such that the executable names were not unique, some builds would be missing.
closes #382