Skip to content

access-mocsy: remove version gtracers and update README#398

Open
harshula wants to merge 1 commit intoapi-v2from
development
Open

access-mocsy: remove version gtracers and update README#398
harshula wants to merge 1 commit intoapi-v2from
development

Conversation

@harshula
Copy link
Copy Markdown
Collaborator

  1. Test CI with this change
  2. It doesn't look like version gtracers is still used: https://github.com/search?q=org%3AACCESS-NRI+gtracers&type=code

@harshula harshula self-assigned this Mar 11, 2026
@github-project-automation github-project-automation bot moved this to New Issues 🌅 in Model Release Mar 11, 2026
@harshula harshula force-pushed the development branch 4 times, most recently from f64ca4f to bd11dc3 Compare March 12, 2026 01:34
@harshula harshula changed the title access-mocsy: version stable should build with cmake access-mocsy: version stable should build with cmake and gcc Mar 12, 2026
@harshula
Copy link
Copy Markdown
Collaborator Author

The workaround is to depend on CMake. However, that does not address the root cause of this problem, which appears to be related to the concretization:

https://github.com/ACCESS-NRI/access-spack-packages/actions/runs/22930104845/job/66561489922#step:20:33

 ==> Concretized 1 spec:
 -   awfffmf  access-mocsy@stable build_system=makefile commit=b136e1a70b9959333b0258b07863ebb05c4ff5f7 platform=linux os=rocky8 target=x86_64 %c,fortran=gcc@13.2.0

For example, the MOM5 SPR has a similar pattern, but it is able to concretize as expected to use CMake with gcc:

==> Concretized 1 spec:
 -   5572z5m  mom5@access-om2~deterministic~ipo build_system=cmake build_type=RelWithDebInfo commit=995fe497e1b91342f465cbed66eaa1336f183ec0 generator=make platform=linux os=rocky8 target=x86_64 %c,fortran=gcc@13.2.0

@harshula harshula force-pushed the development branch 4 times, most recently from 4bd8264 to 88c16cf Compare March 12, 2026 14:38
@harshula
Copy link
Copy Markdown
Collaborator Author

Experiments

    #build_system(conditional("cmake", when="@2025.07.000:"), "makefile", default="cmake")
    build_system("cmake", "makefile", default="cmake")

 -   access-mocsy@stable build_system=makefile commit=b136e1a70b9959333b0258b07863ebb05c4ff5f7 platform=linux os=rocky8 target=x86_64 %c,fortran=gcc@13.2.0
    depends_on("c", type="build")
    depends_on("cxx", type="build")
    depends_on("fortran", type="build")
    depends_on("mpi")

    #build_system(conditional("cmake", when="@2025.07.000:"), "makefile", default="cmake")
    build_system("cmake", "makefile", default="cmake")

 -   access-mocsy@stable build_system=makefile commit=b136e1a70b9959333b0258b07863ebb05c4ff5f7 platform=linux os=rocky8 target=x86_64 %c,cxx,fortran=gcc@13.2.0
    depends_on("c", type="build")
    depends_on("fortran", type="build")
    depends_on("cmake", type="build")
    depends_on("mpi")

    #build_system(conditional("cmake", when="@2025.07.000:"), "makefile", default="cmake")
    build_system("cmake", "makefile", default="cmake")

 -   access-mocsy@stable~ipo~shared build_system=cmake build_type=RelWithDebInfo commit=b136e1a70b9959333b0258b07863ebb05c4ff5f7 generator=make precision=2 platform=linux os=rocky8 target=x86_64 %c,fortran=gcc@13.2.0

@harshula harshula force-pushed the development branch 2 times, most recently from ee7ae0a to ff08beb Compare March 17, 2026 07:16
@harshula harshula changed the title access-mocsy: version stable should build with cmake and gcc access-mocsy: remove version gtracers and update README Mar 17, 2026
@harshula
Copy link
Copy Markdown
Collaborator Author

The original reason for opening this PR is fixed in PR ACCESS-NRI/spack-config#107

* README.md: add `unshallow` instructions
@harshula harshula marked this pull request as ready for review March 17, 2026 13:10
Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README seems fine to me.

The package changes I'll leave it to @dougiesquire to approve.

Copy link
Copy Markdown
Contributor

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshula - LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status
Status: No status
Status: No status
Status: New Issues 🌅

Development

Successfully merging this pull request may close these issues.

3 participants