Open
Conversation
* Hyphen is replaced by underscore.
* __init__.py: review feedback from Peter Scheibel. * spack-repo-index.yaml: suggested by Tommy Gatti.
* .github/build-ci/data/standard_definitions.json: * Change syntax to suit toolchains * Update spack.yaml templates to use Spack v1.x compiler toolchains syntax * .github/workflows/ci.yml: * DEFAULT_SPACK_REF: 'releases/v1.1' * Add a generic intel-oneapi-compilers test * %intel@2021.10.0 can not compile the latest version of python * Require python 3.11.14. * max-parallel increased from 3 to 5. * PR 346: * Update paths to `api-v2` format * Replace `_` from directory name with `-` for package names * Swap filepath and template_value so package name comes first in matrix * Consolidate all refs to packages path under env.PACKAGES_ROOT_DIR Co-authored-by: Tommy Gatti <tommy.gatti@anu.edu.au>
infra: Update to v3, get default spack-config-ref/spack-ref from build-ci workflow, use default container-image-version
This change allows for multiple CMake builds and produces three executables for OM2. Default layouts for ESM1.6 and OM2 are both provided, or a single customised layout can be input using variants (CMake builds only)
* Use the GitHub ACCESS-NRI/gcom repository * Remove gcom from .github/workflows CI exclude list * Build only gcc and intel for gcom --------- Co-authored-by: Tommy Gatti <tommy.gatti@anu.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CI attempts to build the CABLE library for ESM1.6 using the preferred version, which is the head of main. However, development of ESM1.6 is frozen, so the ref of CABLE being used in the model will be unchanged. This means we should only check that the library builds from that specific ref, rather than the head of CABLE.
The library for AM3/ESM3 is a different matter. The coupling interface is significantly different to what it was in ESM1.6, and won't use precisely the same library as was used in ESM1.6. This is why I renamed the manifests to specify
library-esm16-*, as in future will have a library for AM3 that will continue to be built from the head of main.