Skip to content

Get builtin-spack-packages ref from spack-config over settings.json#374

Merged
CodeGat merged 1 commit intov8from
builtin-spack-packages-ref-not-in-settings-json-fix
Apr 16, 2026
Merged

Get builtin-spack-packages ref from spack-config over settings.json#374
CodeGat merged 1 commit intov8from
builtin-spack-packages-ref-not-in-settings-json-fix

Conversation

@CodeGat
Copy link
Copy Markdown
Member

@CodeGat CodeGat commented Apr 16, 2026

See https://github.com/ACCESS-NRI/ACCESS-OM3/actions/runs/24495502824/job/71589426483

Background

In #368 (specifically d485b2d), we remove the builtin-spack-packages key from the settings.json, as spack-config is now the central source of truth for this repo.

However, in the pre-check of build-cds config/settings.json, it still expects that key.

The PR

  • Get builtin-spack-packages ref from spack-configs vX/repos.yaml

@CodeGat CodeGat self-assigned this Apr 16, 2026
@CodeGat CodeGat marked this pull request as ready for review April 16, 2026 07:06
@CodeGat CodeGat requested a review from harshula April 16, 2026 07:07
Copy link
Copy Markdown
Contributor

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@CodeGat CodeGat merged commit 401e061 into v8 Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants