Skip to content

Make default builtin-spack-packages-ref from repos.yaml#262

Merged
CodeGat merged 1 commit intov3from
builtin-ref-default-spack-config
Dec 11, 2025
Merged

Make default builtin-spack-packages-ref from repos.yaml#262
CodeGat merged 1 commit intov3from
builtin-ref-default-spack-config

Conversation

@CodeGat
Copy link
Copy Markdown
Member

@CodeGat CodeGat commented Dec 11, 2025

References ACCESS-NRI/access-spack-packages#353 (comment)

Background

The current default for inputs.builtin-spack-packages-ref is the branch develop. This is consistent with the other inputs.*-ref inputs. However, we are overwriting the currently-set spack-config repos.yaml.

Instead of the default being the bleeding edge of spack/spack-packages, we should default to the ref in the repos.yaml in spack-config at the inputs.spack-config-ref. If there is no value in there either, it should be develop (as is spacks default.

This would mirror the Dockerfile in which spack-config informs the initial versions of the spack packages repositories - if there is no builtin-spack-packages-ref, spack-config informs it.

The PR

  • Update default of builtin-spack-packages-ref to repos.yaml, or develop if not set.

Testing

Tested yq locally in the cases for:

  • No ref of any kind
  • branch/tag/commits in repos.yaml
  • Set via builtin-spack-packages-ref

@CodeGat CodeGat added priority:medium A medium priority issue - has some impact on functionality type:enhancement improvements to code but not new features for:v3 version:MINOR Requires a change to the minor version - features labels Dec 11, 2025
@CodeGat CodeGat self-assigned this Dec 11, 2025
@CodeGat CodeGat requested a review from harshula December 11, 2025 02:29
Copy link
Copy Markdown
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@CodeGat CodeGat merged commit b9aa938 into v3 Dec 11, 2025
@CodeGat CodeGat deleted the builtin-ref-default-spack-config branch December 11, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:v3 priority:medium A medium priority issue - has some impact on functionality type:enhancement improvements to code but not new features version:MINOR Requires a change to the minor version - features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants