Make default builtin-spack-packages-ref from repos.yaml#262
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References ACCESS-NRI/access-spack-packages#353 (comment)
Background
The current default for
inputs.builtin-spack-packages-refis the branchdevelop. This is consistent with the otherinputs.*-refinputs. However, we are overwriting the currently-setspack-configrepos.yaml.Instead of the default being the bleeding edge of
spack/spack-packages, we should default to the ref in therepos.yamlinspack-configat theinputs.spack-config-ref. If there is no value in there either, it should bedevelop(as isspacks default.This would mirror the Dockerfile in which
spack-configinforms the initial versions of the spack packages repositories - if there is nobuiltin-spack-packages-ref,spack-configinforms it.The PR
builtin-spack-packages-reftorepos.yaml, ordevelopif not set.Testing
Tested
yqlocally in the cases for:branch/tag/commits inrepos.yamlbuiltin-spack-packages-ref