Helpers for ACCESS workflow - run-config and post-summary#25
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces helper classes to programmatically generate esmf-trace configuration dictionaries for ACCESS workflow profiling experiments, addressing issue #23. Instead of manually writing YAML configuration files, users can now use builder classes to create run and post-summary configurations from parameters they already have in their notebooks or scripts (branch names, node counts, PET layouts, archive paths, etc.).
Changes:
- Added
ACCESSRunConfigBuilderclass to generate run configuration dicts - Added
ACCESSPostSummaryConfigBuilderclass to generate post-summary configuration dicts - Fixed a minor bug in
postprocess.pywheredefaults.post_base_pathwasn't wrapped inPath() - Added formatting improvements to
config.py(blank lines between overloads)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| src/access/esmf_trace/library.py | Added two new builder classes (ACCESSRunConfigBuilder and ACCESSPostSummaryConfigBuilder) with methods to generate configuration dicts programmatically |
| src/access/esmf_trace/postprocess.py | Fixed missing Path() wrapper for defaults.post_base_path |
| src/access/esmf_trace/config.py | Added blank lines between @overload declarations for better readability |
| src/access/esmf_trace/init.py | Exported ACCESSRunConfigBuilder to the public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
minghangli-uni
force-pushed
the
23-profiling-workflow-api
branch
from
4af49de to
16d64e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #23