Add time & time bnds#70
Merged
joshuatorrance merged 10 commits into66-clone-of-schemafrom Apr 15, 2026
Merged
Conversation
2 tasks
…e from neighbouring branch '66-model-ouput-adding-geospatial'
20 tasks
blimlim
reviewed
Mar 27, 2026
joshuatorrance
added a commit
that referenced
this pull request
Apr 16, 2026
* Made copy of 2-0-0 for new version, only updating version number * Add geospatial extent to model ouput schema (#67) * Added files for geospatial extent * CI is failing to install? Updating to latest release * Added exclusions for 2 linting rules, split command over multiple lines * Does this work for adding another directory to run commands over? * Updated 2-1-0 test with new attributes * Updating schema testing to handle multiple versions * Fixed typo * Trying to fix looping in shell script * Added rules to geospatial attributes * Reordered new rules to satisfy formatter * Apply suggestion from @aidanheerdegen Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au> * Added simple tests for global attrs and geospatial attrs * Added some simple tests for geospatial bounds * Changed geospatial_*_units to use const instead of a pattern * Removed examples from now const units * Removed limits on lat/lon values, updated tests --------- Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au> * Add time & time bnds (#70) * Added time and time_bnds * Added option for units of reference datetime to have seconds * Now supporting alternative calendar options from CF. * Added required to time * Moved non-const time attrs into sub-schemas * Added type to time units * Added additional tests. These won't be run yet, should run after merge from neighbouring branch '66-model-ouput-adding-geospatial' * Removed bounds from the required list. * Added a test for missing bounds * Updated calendar recommendations. @blimlim & @aidanheerdegen * Tweaked time.json to satisfy formatter --------- Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
timeandtime_bndsto the schema.The current proposal requires the bounds to be name
time_bnds. If this is relaxed to allowtime_boundsthen some further updates will be required. Could just use a regex to allow the alternative but this might permit a mix of the two. Compelling them to match will require additional some extra chicanery.Contributes to #68
Closes #69