Update all projections to include {version}#26
Merged
Conversation
aidanheerdegen
previously approved these changes
May 21, 2026
Member
aidanheerdegen
left a comment
aidanheerdegen
left a comment
There was a problem hiding this comment.
LGTM.
Do you think, in this specific case where we want to be quite prescriptive about how the modules should be organised, that we should create a specific check that it looks like system-tools/{name}/{version}?
Member
Author
|
I do like that idea - however the infrastructure doesn't know what is an SDR as opposed to a MDR - they're all just manifests, so we would need to add that in explicitly... |
aidanheerdegen
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Pre- ACCESS-NRI/build-cd#382, the projection injection logic injected the reserved definition
_versioninto the projection. This was a bit convoluted, and difficult to understand for users. In the linked PR, we have updated that logic to instead inject{version}with_versionfor things in the speclist.The PR
*/spack.yamlto include{version}in the projection.