Adding new departure statistics script#45
Adding new departure statistics script#45IsabelTorresMonteiro wants to merge 2 commits intoACCORD-NWP:developfrom
Conversation
|
Congratulations on your first PR! 🎉 Some documentation in doc/src would be great! 👍 |
… 3D-Var and 4D-Var
ewhelan
left a comment
ewhelan
left a comment
There was a problem hiding this comment.
Thanks for this @IsabelTorresMonteiro
- Some questions asked and changes requested.
- You also need to add some documentation.
| @@ -0,0 +1,231 @@ | |||
| ### | |||
There was a problem hiding this comment.
A "help" option would be good for this script. You can look at other Python scripts to see what others have done.
A first blind test with this see the script just hanging. I guess it is waiting for input?
| @@ -0,0 +1,305 @@ | |||
| ### | |||
There was a problem hiding this comment.
Is this file used? It is not installed.
| @@ -0,0 +1,345 @@ | |||
|
|
|||
There was a problem hiding this comment.
Is this file used? It is not installed.
| @@ -0,0 +1,231 @@ | |||
| ### | |||
There was a problem hiding this comment.
Need a hash-bang here:
#!/usr/bin/env python3There was a problem hiding this comment.
I have python3 in my .bashrc, I probably didn't notice
| INPUT1="{}".format(Loop1) | ||
| INPUT2="{}".format(Loop2) | ||
| INPUT3="{}".format(Loop3) | ||
| #load data from ASCII from odb |
There was a problem hiding this comment.
How is this ASCII produced? A clearer usage/help function is needed.
There was a problem hiding this comment.
These scripts were developed a few years ago the full package includes a sh script which generates the ASCII files and a py script for statistics and visualisation. The full package (sh+py) as a README (txt) describying the scripts and usage. dep_stats.py is argparse if you do dep_stats.py -h you get information on the input filenames.
2 participants
departures statistics by time slot