Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheaper gibs/debris when FPS is low. #453

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Conversation

StrawWagen
Copy link

@StrawWagen StrawWagen commented Jan 17, 2025

Disable some Gib/Debris features when fps is below 45, 40, 35, 25, and 15

Was getting < 15 FPS on a server, and when i looked around, a destroyed build was the culprit.

I know, anyone with brains will just turn gibs off, but they're awesome, and this change is really for the "average" player who doesn't care about settings, they just leave the "laggy" server and never come back.

Can easily disable this system with a convar for the real gmodders who aren't scared of some low fps, and i put it in the clientside settings with everything else.

image

Disable some Gib/Debris features when fps is below 45, 40, 30, and 20

Was getting < 15 FPS on a server, with hundreds of gibs on the map.

You can disable all of these features normally pretty much, but the average player doesn't turn stuff off, they just leave the "laggy" server and never come back.
+ increase targets a tad
Copy link
Member

@marchc1 marchc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested in game, but this looks good to me. Will leave actually merging up to someone else just in case I missed something

Also will change target to dev (we can cherry pick them to master)

@marchc1 marchc1 changed the base branch from master to dev January 17, 2025 05:11
Copy link
Member

@thecraftianman thecraftianman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid to me other than the one bit I had a question about

lua/acf/damage/debris_cl.lua Outdated Show resolved Hide resolved
@marchc1 marchc1 merged commit fca5ac8 into ACF-Team:dev Jan 18, 2025
2 checks passed
@StrawWagen StrawWagen deleted the gib-LOD branch January 18, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants