Isolating bsdd - #50
Open
Ghesselink wants to merge 2 commits into
Open
Conversation
Ghesselink
marked this pull request as ready for review
February 26, 2023 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local tests can be invoked by :
python3 check_bsdd_v2.py --task 4 -db 0 -i input.ifcThe output is a JSON file
Two additional questions:
In the main.py folder, there is some further parsing of bsdd. Is this purely for the frontend or something we want to isolate for testing purposes as well? https://github.com/Ghesselink/ifc-pipeline-validation/blob/6333d0c5424f0d33cba31fe89cea18d27284db7d/application/main.py#L599-L605
Johan mentioned a --task functionality for the command line. Does this imply that the idea is to extent the script to other tasks (syntax, bsdd, gherkin, schema) ?