Allow configurable id type for MmapShmemProvider #3416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Sep 10, 2025
| @@ -723,7 +722,11 @@ pub mod unix_shmem { | |||
| /// At most [`MAX_MMAP_FILENAME_LEN`] - 2 bytes from filename will be used. | |||
| /// | |||
| /// This will *NOT* automatically delete the shmem files, meaning that it's user's responsibility to delete them after fuzzing | |||
| pub fn new(map_size: usize, filename: impl AsRef<Path>) -> Result<Self, Error> { | |||
| pub fn new( | |||
There was a problem hiding this comment.
Maybe use two distinct constructors instead of the extra bool?
There was a problem hiding this comment.
I think having the parameter here makes it easy to create it dynamically from MmapShMemProvider, and there we do have both new and with_filename_as_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to configure
MmapSharedProviderto use filename/fd as id, instead of always using fd in apple and filename in linuxChecklist
./scripts/precommit.shand addressed all comments