Feature/object detector with aruco marker#5
Open
AntoniRL wants to merge 37 commits intohumble-develfrom
Open
Conversation
4 tasks
macmacal
requested changes
Mar 24, 2026
Contributor
macmacal
left a comment
There was a problem hiding this comment.
For the starters, please update the CHANGELOG
macmacal
requested changes
Mar 26, 2026
Contributor
|
To enforce the new ruleset for merging PRs i needed to update the CICD with #6 . Please pull the |
…bjects_manager into feature/object-detector
macmacal
requested changes
Apr 3, 2026
| add_compile_options(-Wall -Wextra -Wpedantic) | ||
| endif() | ||
|
|
||
| set(HW_IF_INCLUDE_DEPENDS |
Contributor
There was a problem hiding this comment.
It would be perfect to create to lists:
set(ROS_DEPENDS
cv_bridge
geometry_msgs
moveit_msgs
moveit_ros_planning_interface
rosidl_default_generators
std_msgs
sensor_msgs
tf2
tf2_ros
tf2_geometry_msgs
)
set(PROJECT_DEPENDS
OpenCV
yaml-cpp
${ROS_DEPENDS}
)Then use it for:
foreach(dependency IN ITEMS ${PROJECT_DEPENDS})
find_package(${dependency} REQUIRED)
endforeach()and for:
ament_target_dependencies(
${PROJECT_NAME}_node
ament_index_cpp
rclcpp
${ROS_DEPENDS}
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a service that returns a list of detected blocks marked with ArUco markers.
Motivation and Context
This is the first step to obtain the object position for RL algorithms. Later, it will be replaced with detection using a neural network.
How Has This Been Tested?
Tested with the real robot, and with two test scripts.
Realted PR
Checklist:
Clickup task: 869cbbrjb