Skip to content

Feature/object detector with aruco marker#5

Open
AntoniRL wants to merge 37 commits intohumble-develfrom
feature/object-detector
Open

Feature/object detector with aruco marker#5
AntoniRL wants to merge 37 commits intohumble-develfrom
feature/object-detector

Conversation

@AntoniRL
Copy link
Copy Markdown

@AntoniRL AntoniRL commented Mar 24, 2026

Description

Added a service that returns a list of detected blocks marked with ArUco markers.

Motivation and Context

This is the first step to obtain the object position for RL algorithms. Later, it will be replaced with detection using a neural network.

How Has This Been Tested?

Tested with the real robot, and with two test scripts.

Realted PR

Checklist:

  • All TODOs in the code has been resolved or linked with a proper issue.
  • Code is (auto)formatted.
  • Documentation (README/CHANGELOG/Wiki/etc) has been updated.
  • All automatic checks passed.

Clickup task: 869cbbrjb

Copy link
Copy Markdown
Contributor

@macmacal macmacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the starters, please update the CHANGELOG

@macmacal
Copy link
Copy Markdown
Contributor

To enforce the new ruleset for merging PRs i needed to update the CICD with #6 . Please pull the humble-devel and push anything - the pre-commit (prek) job should start automatically.

Copy link
Copy Markdown

@sivral sivral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

add_compile_options(-Wall -Wextra -Wpedantic)
endif()

set(HW_IF_INCLUDE_DEPENDS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be perfect to create to lists:

set(ROS_DEPENDS
    cv_bridge
    geometry_msgs
    moveit_msgs
    moveit_ros_planning_interface
    rosidl_default_generators
    std_msgs
    sensor_msgs
    tf2
    tf2_ros
    tf2_geometry_msgs
)
set(PROJECT_DEPENDS
    OpenCV
    yaml-cpp
    ${ROS_DEPENDS}
)

Then use it for:

foreach(dependency IN ITEMS ${PROJECT_DEPENDS})
  find_package(${dependency} REQUIRED)
endforeach()

and for:

ament_target_dependencies(
  ${PROJECT_NAME}_node
  ament_index_cpp
  rclcpp
  ${ROS_DEPENDS}
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants