Fix HTML format fallback to generate both XLSX and CSV as documented by Copilot · Pull Request #386 · AMD-AGI/Primus

Copilot · 2025-12-17T10:20:39Z

The HTML format handler displayed a warning saying "using xlsx+csv" but only generated XLSX files, creating an inconsistency between the warning message and actual behavior.

Changes:

Updated HTML format handler to generate both XLSX and CSV files when HTML is requested, matching the warning message
Clarified documentation across all functions to explicitly state HTML format is not yet supported and falls back to xlsx+csv
Improved warning message from "using xlsx+csv" to "generating xlsx+csv instead" for clarity

The implementation now generates the expected output:

# When output_format="html" is specified:
# Before: Only generated .xlsx file
# After: Generates both .xlsx file and multiple .csv files in subdirectory

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: gphuang <13152353+gphuang@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes an inconsistency in the HTML format handler where it warned about generating "xlsx+csv" files but only actually generated XLSX files. The implementation has been updated to match the documented behavior by generating both XLSX and CSV files when HTML format is requested.

Key changes:

HTML format handler now generates both XLSX and CSV files as documented
Warning message improved from "using xlsx+csv" to "generating xlsx+csv instead" for clarity
Documentation updated across all functions to explicitly mention HTML format fallback behavior

Comments suppressed due to low confidence (1)

primus/backends/megatron/training/mlflow_artifacts.py:370

Variable dfs is not used.

            dfs = generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-17T11:17:18Z

primus/backends/megatron/training/mlflow_artifacts.py

+            # CSV: Multiple files in a subdirectory
+            csv_subdir = os.path.join(output_dir, report_name)
+            os.makedirs(csv_subdir, exist_ok=True)
+            generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)


Inconsistent variable naming: The return value from generate_perf_report_pytorch is stored in 'xlsx_dfs' for consistency (line 383), but the CSV generation call on line 393 ignores the return value. For consistency with line 370 (the "all"/"csv" branch), this should be stored in a variable like 'csv_dfs' even if not immediately used, to maintain code consistency.

Suggested change

generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)

csv_dfs = generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)

Copilot · 2025-12-17T11:17:18Z

primus/backends/megatron/training/mlflow_artifacts.py

        if output_format == "html":
-            warning_rank_0("[TraceLens] HTML format not yet supported, using xlsx+csv")
-            # Fall through to xlsx
+            warning_rank_0("[TraceLens] HTML format not yet supported, generating xlsx+csv instead")
+            # Generate both XLSX and CSV formats as fallback
+            # XLSX: Single file with multiple tabs
            xlsx_path = os.path.join(output_dir, f"{report_name}_analysis.xlsx")
-            dfs = generate_perf_report_pytorch(trace_file, output_xlsx_path=xlsx_path)
+            xlsx_dfs = generate_perf_report_pytorch(trace_file, output_xlsx_path=xlsx_path)
            if os.path.exists(xlsx_path):
+                log_rank_0(
+                    f"[TraceLens] Generated XLSX report with {len(xlsx_dfs)} tabs: {os.path.basename(xlsx_path)}"
+                )
                generated_files.append(xlsx_path)
+
+            # CSV: Multiple files in a subdirectory
+            csv_subdir = os.path.join(output_dir, report_name)
+            os.makedirs(csv_subdir, exist_ok=True)
+            generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)
+
+            # Collect all generated CSV files
+            csv_files = glob.glob(os.path.join(csv_subdir, "*.csv"))
+            if csv_files:
+                log_rank_0(f"[TraceLens] Generated {len(csv_files)} CSV files for {report_name}")
+                generated_files.extend(csv_files)


Code duplication: The HTML format handler duplicates the logic from the "all" branch (lines 356-376). Consider refactoring to avoid duplication - for example, treating output_format == "html" the same as "all" by changing the condition on line 356 to 'if output_format in ("all", "xlsx", "html")' and line 366 to 'if output_format in ("all", "csv", "html")', then only keeping the warning message unique to the HTML case.

Initial plan

9303b0e

Copilot AI assigned Copilot and gphuang Dec 17, 2025

Copilot AI mentioned this pull request Dec 17, 2025

Feat/12 tracelens integration #377

Closed

Copilot started work on behalf of gphuang December 17, 2025 10:21 View session

Copilot AI and others added 2 commits December 17, 2025 10:25

Fix HTML format to generate both XLSX and CSV as documented

bf52c33

Co-authored-by: gphuang <13152353+gphuang@users.noreply.github.com>

Use clearer variable names in HTML format handler

b50ecff

Co-authored-by: gphuang <13152353+gphuang@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] WIP Address feedback from PR #377 on tracelens integration~~ Fix HTML format fallback to generate both XLSX and CSV as documented Dec 17, 2025

Copilot AI requested a review from gphuang December 17, 2025 10:29

Copilot finished work on behalf of gphuang December 17, 2025 10:29

gphuang marked this pull request as ready for review December 17, 2025 11:13

Copilot AI review requested due to automatic review settings December 17, 2025 11:13

gphuang requested review from Xiaoming-AMD, limou102 and wenxie-amd as code owners December 17, 2025 11:13

gphuang merged commit ee94bf7 into feat/12-tracelens-integration Dec 17, 2025
1 check failed

gphuang deleted the copilot/sub-pr-377-375adac1-1aab-4737-b318-041a55c4aa3d branch December 17, 2025 11:13

Copilot started reviewing on behalf of gphuang December 17, 2025 11:14 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix HTML format fallback to generate both XLSX and CSV as documented#386

Fix HTML format fallback to generate both XLSX and CSV as documented#386
gphuang merged 3 commits intofeat/12-tracelens-integrationfrom
copilot/sub-pr-377-375adac1-1aab-4737-b318-041a55c4aa3d

Copilot AI commented Dec 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

Copilot AI Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)
	csv_dfs = generate_perf_report_pytorch(trace_file, output_csvs_dir=csv_subdir)

Conversation

Copilot AI commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 17, 2025 •

edited

Loading