Skip to content

drivers:jtag: Add time Out to avoid JTAG hang #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
modolaty wants to merge 1 commit into
base: integ_sp8
Choose a base branch
from
Open

drivers:jtag: Add time Out to avoid JTAG hang #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions drivers/jtag/jtag-aspeed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,14 +548,20 @@ static int aspeed_jtag_isr_wait(struct aspeed_jtag *aspeed_jtag, u32 bit)

static int aspeed_jtag_wait_shift_complete(struct aspeed_jtag *aspeed_jtag)
{
long Lres = 0;
int res = 0;
u32 status = 0;
u32 iterations = 0;

if (!aspeed_jtag->irq) {
res = wait_event_interruptible(aspeed_jtag->jtag_wq,
aspeed_jtag->flag &
ASPEED_JTAG_INTCTRL_SHCPL_IRQ_STAT);
Lres = wait_event_interruptible_timeout(aspeed_jtag->jtag_wq,
aspeed_jtag->flag &
ASPEED_JTAG_INTCTRL_SHCPL_IRQ_STAT,
(long)msecs_to_jiffies(1000));
Copy link
Copy Markdown
Collaborator

@ashok2ku ashok2ku Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if this work - is long required - msecs_to_jiffies(1000);

if (Lres == 0) {
Copy link
Copy Markdown
Collaborator

@ashok2ku ashok2ku Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add
if (Lres < 0)
return Lres;

dev_err(aspeed_jtag->dev,
"aspeed_jtag_wait_shift_complete: timeout after 1 sec \n");
}
Copy link
Copy Markdown
Collaborator

@ashok2ku ashok2ku Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add - return -ETIMEDOUT;

aspeed_jtag->flag &= ~ASPEED_JTAG_INTCTRL_SHCPL_IRQ_STAT;
} else {
while ((status & ASPEED_JTAG_INTCTRL_SHCPL_IRQ_STAT) == 0) {
Expand Down