Closed
Conversation
During SFS commands such Get Firmware Veresion and Update Firmware Version, once a request is sent completely on an MCTP endpoint such as 17 or 20, delete neighbor MCTP endpoints such as 15 and 16 and add them back when SFS either responds or times out. This is to prevent any simultaneous requests on other endpoints from creating out of sequence packets and thus bringing down MCTP endpoints due to out of sequence errors. Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
mahkurap
requested changes
Feb 16, 2026
Collaborator
mahkurap
left a comment
mahkurap
left a comment
There was a problem hiding this comment.
please update the commit title and the log message with an example. Also run the clang formatting tool before committing the PR>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During SFS commands such Get Firmware Veresion and Update Firmware Version, once a request is sent
completely on an MCTP endpoint such as 17 or 20,
delete neighbor MCTP endpoints such as 15 and 16
and add them back when SFS either responds or
times out.
This is to prevent any simultaneous requests on
other endpoints from creating out of sequence
packets and thus bringing down MCTP endpoints due
to out of sequence errors.