Improve logic for MTSplit
#66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariodruiz
added a commit
to mariodruiz/Riallto
that referenced
this pull request
Oct 15, 2024
* Add test to check for non anonymous kernels and MTSplit and MTConcat * Do not trace application again if args are the same * Fix call * Remove unused test * Add testcases with float numbers * Add memtile reduce test * Flake8 * Fix source name * Fix name * Fix behavior * Add more comprehensive tests * Flake8 * Increase tolerance * Set random seed * Raise error if datatype not supported for mt links * Remove trailing whitespace and some flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem solved by the commit
Double tracing the app leads to error as discussed in #63 for non anonymous kernels.
How is the problem solved?
'<' not supported between instances of 'NoneType' and 'NoneType'Are there any risks associated to the change?
No
Is there a documentation impact?
No
Checklist
Please provide screenshots (if applicable)
Related issues
#63