Update README for C++20#652
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s installation requirements in the README to reflect newer toolchain baselines.
Changes:
- Update the stated compiler requirement to C++20.
- Update documented GPU requirements to CUDA >= 12 and ROCm >= 6.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ### Requirements | ||
|
|
||
| The compilations of *PeleLMeX* requires a C++17 compatible compiler (GCC >= 8 or Clang >= 3.6) as | ||
| The compilations of *PeleLMeX* requires a C++20 compatible compiler as |
There was a problem hiding this comment.
Grammar: "The compilations of PeleLMeX requires" is ungrammatical (plural subject with singular verb). Consider rephrasing to "Compiling PeleLMeX requires..." or "The compilation of PeleLMeX requires...".
| The compilations of *PeleLMeX* requires a C++20 compatible compiler as | |
| Compiling *PeleLMeX* requires a C++20 compatible compiler as |
| [open-mpi](https://www.open-mpi.org/software/ompi/v4.1/) is a suitable option if MPI is not already available on your platform. | ||
|
|
||
| Finally, when building with GPU support, CUDA >= 11 is required with NVIDIA GPUs and ROCm >= 5.2 is required with AMD GPUs. | ||
| Finally, when building with GPU support, CUDA >= 12 is required with NVIDIA GPUs and ROCm >= 6 is required with AMD GPUs. |
There was a problem hiding this comment.
The PR title mentions only updating the README for C++20, but this change also bumps the documented GPU requirements (CUDA/ROCm). Please update the PR title/description to reflect this additional requirements change, or split it into a separate PR for clarity.
No description provided.