Add option to loop turbinflow planes in time#667
Merged
baperry2 merged 8 commits intoAMReX-Combustion:developmentfrom Apr 1, 2026
Merged
Add option to loop turbinflow planes in time#667baperry2 merged 8 commits intoAMReX-Combustion:developmentfrom
baperry2 merged 8 commits intoAMReX-Combustion:developmentfrom
Conversation
Contributor
|
Thanks for doing this, I was starting on an overcomplicated approach! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a runtime flag to make TurbInflow “swirl-type” (time-stamped) turbulence plane data repeat periodically in time, so long simulations can reuse a finite inflow dataset.
Changes:
- Introduces
turbinflow.<name>.time_periodicparameter inTurbParmand wires it intoParmParse. - Implements time-wrapping logic for swirl-type inflows when reading/filling turbulence planes.
- Documents the new input option in Sphinx docs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Source/Utility/TurbInflow/turbinflow.H | Adds time_periodic field to TurbInflow parameters. |
| Source/Utility/TurbInflow/turbinflow.cpp | Parses time_periodic and wraps requested time for swirl-type inflows. |
| Docs/sphinx/Utility.rst | Documents the new time_periodic runtime option. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baperry2
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a flag
turbinflow.__.time_periodic, which enables users to loop turbinflow planes periodically in time.