PERF: more optimization at compile time #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This potentially fixes #703 by adding compile time optimization |
|
Comparing wheel size https://github.com/ANTsX/ANTsPy/actions/runs/10694558339 vs older https://github.com/ANTsX/ANTsPy/actions/runs/10676912823 The additional optimization adds a few Mb, but I'd say it's worth it for the speed increase. |
|
I haven't tested Windows, but from what I can tell in the scripts it should use default optimization settings in ITK, so hopefully it's good to go. Linux and Mac seem substantially faster, so I'm thinking to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might affect wheel size, making a PR so I can make some wheels to compare