Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix nanobind memory leaks #734

Merged
merged 1 commit into from
Nov 14, 2024
Merged

WIP: Fix nanobind memory leaks #734

merged 1 commit into from
Nov 14, 2024

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Nov 13, 2024

Need to add destructor for memory allocated with new in the wrap function

@cookpa
WIP: Fix nanobind memory leaks
142af47 
Need to add destructor for memory allocated with new in the wrap function
@cookpa cookpa mentioned this pull request Nov 13, 2024
Closed
@coveralls
Copy link

Coverage Status

coverage: 85.341%. remained the same
when pulling 142af47 on cookpa:nb_destruct
into 637912b on ANTsX:master.

@cookpa cookpa marked this pull request as ready for review November 14, 2024 19:48
@cookpa
Copy link
Member Author

cookpa commented Nov 14, 2024

I think this fixes the similarity memory leak from #117 that resurfaced after the switch to nanobind.

@cookpa cookpa merged commit afc7228 into ANTsX:master Nov 14, 2024
3 checks passed
@cookpa cookpa deleted the nb_destruct branch November 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cookpa @coveralls