Make code compatible with SVT-AV1 3.0 #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wantehchang , we can probably merge the C code without bumping the version for now. That will fix #2589 . If more API changes happen, we will clean them along the way |
wantehchang
reviewed
Feb 11, 2025
|
Actually, we just need to fix whatever is in here: https://gitlab.com/AOMediaCodec/SVT-AV1/-/blob/master/.gitlab/workflows/linux/libavif_api_job_fix.patch?ref_type=heads |
|
Yes, I consulted libavif_api_job_fix.patch when I reviewed your pull request. |
|
Merging the .c fix will break their CI because SVT_AV1_VERSION_MAJOR has not been bumped. Let's wait for the last minute before our 1.2 release. |
wantehchang
requested changes
Feb 12, 2025
vrabaud
changed the title
1480c1
reviewed
Feb 13, 2025
wantehchang
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.