-
Notifications
You must be signed in to change notification settings - Fork 41
feat: Stricter DevRel classification & GitHubToolkit fixes #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -104,13 +104,13 @@ async def execute(self, query: str) -> Dict[str, Any]: | |||||||||||||
if classification == "contributor_recommendation": | ||||||||||||||
result = await handle_contributor_recommendation(query) | ||||||||||||||
elif classification == "repo_support": | ||||||||||||||
result = "Not implemented" | ||||||||||||||
result = {"status": "not_implemented", "message": "Repo support not implemented yet"} | ||||||||||||||
# result = await handle_repo_query(query) | ||||||||||||||
elif classification == "issue_creation": | ||||||||||||||
result = "Not implemented" | ||||||||||||||
# result = await handle_issue_creation(query) | ||||||||||||||
Comment on lines
110
to
111
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent return type for issue_creation branch While you fixed the Apply this diff to maintain consistency: elif classification == "issue_creation":
- result = "Not implemented"
+ result = {"status": "not_implemented", "message": "Issue creation not implemented yet"}
# result = await handle_issue_creation(query) 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||
elif classification == "documentation_generation": | ||||||||||||||
result = "Not implemented" | ||||||||||||||
result = {"status": "not_implemented", "message": "Documentation generation is not yet implemented"} | ||||||||||||||
# result = await handle_documentation_generation(query) | ||||||||||||||
elif classification == "web_search": | ||||||||||||||
result = await handle_web_search(query) | ||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix environment variable syntax and formatting issues
The new
BOT_NAME
environment variable has incorrect syntax with spaces around the equal sign and missing quotes around the value. Additionally, there are formatting issues that should be addressed.Apply this diff to fix the syntax and formatting:
This fixes:
#
in the comment header for consistency#
in the inline comment📝 Committable suggestion
🧰 Tools
🪛 dotenv-linter (3.3.0)
[warning] 26-26: [UnorderedKey] The LANGSMITH_PROJECT key should go before the LANGSMITH_TRACING key
[warning] 29-29: [EndingBlankLine] No blank line at the end of the file
[warning] 29-29: [SpaceCharacter] The line has spaces around equal sign
[warning] 29-29: [ValueWithoutQuotes] This value needs to be surrounded in quotes
🤖 Prompt for AI Agents