Correct skipped-simulation accounting by counting DB-hit results as skipped

[Copilot]

Skipped simulation accounting is now aligned so that when a previously seen deck is served from DB, those iterations are counted as skipped simulations in the reported (<simulated> + <skipped>) totals.

• Skipped-counter semantics

  • Restored direct skipped accounting in algorithms.cpp so DB-hit reused results contribute to skipped_simulations.
  • Removed the helper that excluded DB-only coverage from skipped counts.

• Regression coverage

  • Added/updated focused DB regression coverage in sim_test.cpp:
    • warm DB with a climb run using no-db-load
    • assert warmup skipped simulations are zero (Z == 0) for the no-DB-load warmup run
    • rerun with DB load enabled using beam
    • parse Evaluated X decks (Y + Z simulations). and assert cached run skipped count is non-zero (Z > 0), confirming DB-hit results are counted as skipped.

• Snippet (core behavior)

  if (!emplace_rv.second)
  {
      skipped_simulations += prev_results.second;
  }

[!WARNING]

[APN-Pucky]

@copilot if the database is hit the results taken from the database should be counted as skipped, right?

[Copilot]

@copilot if the database is hit the results taken from the database should be counted as skipped, right?

Yes — agreed. I updated it so DB-hit results are counted as skipped simulations again (commit 330a16f).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[APN-Pucky]

@copilot also make sure that warmup skipped is zero asserted.

[Copilot]

@copilot also make sure that warmup skipped is zero asserted.

Done in 5ff5f04: the test now explicitly asserts warmup skipped is zero (no-db-load warmup) before checking cached skipped behavior.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• dl.google.com
  • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)