Full soil info isn't returned when FullSoil radius is specified#44
Merged
ric394 merged 2 commits intoAPSIMInitiative:masterfrom Sep 12, 2025
Merged
Full soil info isn't returned when FullSoil radius is specified#44ric394 merged 2 commits intoAPSIMInitiative:masterfrom
ric394 merged 2 commits intoAPSIMInitiative:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where full soil information wasn't being returned when a FullSoil radius was specified in API queries. The fix ensures that all related soil data (organic matter, water properties, and analysis) is properly included in the database query results.
- Added Entity Framework Include statements to load related soil data
- Added unit tests to verify that all soil properties are populated in the response
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| API/Services/SoilServices.cs | Added Include statements for SoilOrganicMatter, SoilWater, and Analysis to ensure complete soil data is loaded |
| Tests/UnitTest.cs | Added assertions to verify that soil properties are not null in radius-based queries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ric394
approved these changes
Sep 12, 2025
ric394
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #43