Skip to content

Add flag leaf data for Temora#11170

Merged
ric394 merged 1 commit intoAPSIMInitiative:masterfrom
hut104:Master
Apr 1, 2026
Merged

Add flag leaf data for Temora#11170
ric394 merged 1 commit intoAPSIMInitiative:masterfrom
hut104:Master

Conversation

@hut104
Copy link
Copy Markdown
Contributor

@hut104 hut104 commented Mar 31, 2026

working on #10516

@hut104 hut104 added the Ready for Software Review Add this to your pull request when you would like it to be reviewed by the software team label Apr 1, 2026
@hut104
Copy link
Copy Markdown
Contributor Author

hut104 commented Apr 1, 2026

@par456 and @ric394
The change simply adds three observations to a single experience in the GxExM test set.
The stats are different because N has increased by 3 and the new data are added to show that the final leaf number was lower than predicted (therefore the goodness of fit is reduced).
A following PR will show changes to the parameterisation to address this.
I suggest merging this change if you agree.

@ric394
Copy link
Copy Markdown
Contributor

ric394 commented Apr 1, 2026

@APSIMInitiative/reference-panel

This PR adds 3 additional observations to a single GxExM datasets.

The issue has been documented #10516

The file changes are here.

The changes in stats can be found here.

As this PR is only adding data it will be merged today. Please comment if there is an issue.

@ric394 ric394 merged commit 1adefe6 into APSIMInitiative:master Apr 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready for Software Review Add this to your pull request when you would like it to be reviewed by the software team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants