Refactor #10
Merged
Refactor #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrlzy
force-pushed
the
refactor/refactor-data-layer
branch
from
3fbba85 to
7bf79ff
Compare
* Migrate plugins and dependencies to version catalog * Remove kapt and migrate jvmTarget to jvmToolchain
* Configure koin dependency injection * Remove hilt * Fix koin
* Add ktlint code styling * Add ktlint to build workflow * Update jobs dependencies in build.yml * Migrate dependency injection from Hilt to Koin (#14) * Configure koin dependency injection * Remove hilt * Fix koin * Add ktlint code styling * Add ktlint to build workflow * Update jobs dependencies in build.yml * Update from refactor-data-layer * Remove hilt dependencies * Use Drop dependency from version catalog
shubertm
requested changes
Nov 27, 2025
app/src/main/java/dev/arkbuilders/drop/app/data/helper/AvatarHelperImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/arkbuilders/drop/app/presentation/send/SendViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/dev/arkbuilders/drop/app/presentation/send/SendViewModel.kt
Outdated
Show resolved
Hide resolved
* Remove obsolete SDK check in NetworkStatusImpl and Use Timber for logging in SendFileSubscriberImpl * Remove Hilt plugin from version catalogs * Remove unused code * Replace Log with Timber * Downgrade min SDK from 29 to 26
* Remove check job from build job dependencies * Fix lint
shubertm
reviewed
Dec 11, 2025
Member
shubertm
left a comment
shubertm
left a comment
There was a problem hiding this comment.
Thanks for the improvements. I see legacy code for saving files. I will consider it for UI/UX QA
kirillt
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.