Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Description
We want to avoid the "no connection" screen at all cost. That's why same JSON files (crypto rates and fiat rates) should be included into the installer itself. The update schedule is not so important here though, even weekly is fine for the start.
When the app fails to refresh rates, it should also check if we've already downloaded the rates at least once. If yes, then take the downloaded exchange rates. If no, take the pre-packaged rates from the fallback JSONs.
Now, it'll be guaranteed that the app works offline under any circumstances. Otherwise, this could become a problem when we remove our cache repo and query the APIs directly. There will be much more potential reasons why updating could fail: server unreachable, exceeding quota, not supported in user's region, etc.
✅ Changes
fetch.yml🎯 How to Test
🆘 TODO
ADJUST PATH HEREcomments.ADJUST PATH HEREcomments.