Skip to content

Conversation

@hieuwu
Copy link
Member

@hieuwu hieuwu commented Apr 20, 2025

Improve read me with more sections to showcase the app and tech stack

@hieuwu hieuwu requested a review from kirillt April 20, 2025 04:13
@hieuwu hieuwu self-assigned this Apr 20, 2025
@mdrlzy
Copy link
Member

mdrlzy commented Apr 20, 2025

Looks awesome!
Did you use chatgpt? 😅

  • Can you mention orbit mvi?
    https://github.com/orbit-mvi/orbit-mvi
    Orbit is a Redux/MVI-like library - but without the baggage. It's so simple we think of it as MVVM+

  • And also compose-destinations library
    https://github.com/raamcosta/compose-destinations
    Annotation processing library for type-safe Jetpack Compose navigation with no boilerplate.

  • I think there is no need to mention Gradle. Kotlin + Android == Gradle

  • Also you can omit cryptoicons and fiaticons in modules graph. These are just "folders" for icons, because you can't create folders in resources.

@hieuwu
Copy link
Member Author

hieuwu commented Apr 20, 2025

Looks awesome! Did you use chatgpt? 😅

  • Can you mention orbit mvi?
    https://github.com/orbit-mvi/orbit-mvi
    Orbit is a Redux/MVI-like library - but without the baggage. It's so simple we think of it as MVVM+
  • And also compose-destinations library
    https://github.com/raamcosta/compose-destinations
    Annotation processing library for type-safe Jetpack Compose navigation with no boilerplate.
  • I think there is no need to mention Gradle. Kotlin + Android == Gradle
  • Also you can omit cryptoicons and fiaticons in modules graph. These are just "folders" for icons, because you can't create folders in resources.

Nice catch 😂 I used Grok for this

@hieuwu hieuwu requested a review from mdrlzy April 27, 2025 06:42
@hieuwu
Copy link
Member Author

hieuwu commented Apr 27, 2025

Hi @mdrlzy , just update the PR according to your feedbacks. Please review

@hieuwu hieuwu merged commit 5626416 into main Apr 28, 2025
2 checks passed
@hieuwu hieuwu deleted the fix/improve-readme branch May 12, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants