-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement socket_bind and socket_accept #41
base: master
Are you sure you want to change the base?
Conversation
What I basically need is a function that I can call every X ms. which says: "Do you have any data in your buffers that has CONNECT or CLOSE in them". Then, as long as the RxIrq is attached properly we shouldn't need this weird pinging (it's also not thread-safe). |
A problem with the ATParser library is that it only processes information when you ask it to, which is great for simple request/response patterns, but not for real OOB data like sockets connecting. I implemented a second buffer which handles |
a0483f0
to
6a13d12
Compare
…nged in recv() call so we don't route back to a closed TCPSocket
Ping @geky @sarahmarshy |
Ping again @geky @sarahmarshy |
Outdated, closing... |
@SeppoTakalo Since when is outdated a reason to close issues without discussion?! I want to have a discussion about the approach first before rebasing this. /cc (again!) @sarahmarshy @geky |
For issues, its not valid but for pull requests it is a valid reason. Ownership of this driver is now transferred to my team and I only checked that this PR seems to be abandoned for a while, therefore I closed. ESP driver have gone lot of rework since this have been published so I cannot know whether this is valid anymore. For improvements, I would like to first see the failing testcase or liked issue. From testcases, I can see that this driver fails on |
@SeppoTakalo Yes, it's abandoned because no-one has given a second to look at the PR. What am I supposed to do in that case? I've been trying to get someone to look at the way this is implemented for the last 5 months.
|
The code shouldn't have divereged too much. Not just this pr, but all features going into ESP8266Interface have been frozen for a while (sorry @janjongboom!). |
This is now ticket ONME-3341 and we can take ownership of the work within our sprints. |
@geky @sarahmarshy
Work in progress... Tested with https://developer.mbed.org/teams/ST/code/mbed-os-tcp-server-example/
I'd like some feedback on the approach (working around the ATParser library quirks) before cleaning it up.