-
Notifications
You must be signed in to change notification settings - Fork 1
[20] Fix NextJS example "showExperiments" query string and update contributing guide #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomStrepsil
wants to merge
44
commits into
ASOS:main
Choose a base branch
from
TomStrepsil:bug/fix-nextjs-example-show-experiments-query-string-and-update-contributing-guide
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename to proper module namespace * update docs links * update versions * web toggle point in readme title * fixup changelog from revised 0.x range * 2.0.0 -> 0.5.0 in oss version scheme * fix broken link syntax in CHANGELOG * consistent quoting * more version history issues * fixup module name in jsdoc * add web remove sdkInstanceProvider * remove SDKInstanceProvider * fixup jsdoc dedupe * tweak * clarity re: ssr package * casing etc
…anged rendering engine? May need a fuzzier match, or a stable ubuntu image
TomStrepsil
commented
Feb 9, 2025
2 tasks
2 tasks
* update workflows * version * typo * update chromium linux snaps * versions for serve update * package.json repository field * update root package.lock * bugs & directories/doc fields * fix changelog --------- Co-authored-by: Tom Pereira <[email protected]>
…y-string-and-update-contributing-guide
Co-authored-by: Tom Pereira <[email protected]>
…y-string-and-update-contributing-guide
This reverts commit d610686.
0a3eeb6
to
a36bc30
Compare
…ple-show-experiments-query-string-and-update-contributing-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
resolves #20
Details
This PR fixes the issue whereby the
?showExperiments
querystring handling in theNextJs
example is ineffective.Originally, the NextJs example demonstrated the
ssr
package, despite this package being superfluous for a platform that has native props-serialization. When an opportunity arose to demonstrate thessr
package elsewhere (made in v0.2.0), the NextJs example was moved to more canonical approach for Next. However, the debug querystring to make the<script type="application/json">
inserted byssr
visible would no longer do anything. This PR fixes that mistake.Scout Rule:
README.md
s to NPM packages, so npmjs.com doesn't appear emptyREADME.md
features
package to the tail of the document, near the react-specific store factoriesreact-dom/server
, toopull_request_template.md
to prefix the issue with "resolves " and use hash-shorthandhomepage
topackage.json
s, again to link to appropriate package from that field on npmjs.comREADME.md
, which had missed a directory level@asos/syker
, where this file was copied from?CheckList
main
.