Skip to content

[20] Fix NextJS example "showExperiments" query string and update contributing guide #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

TomStrepsil
Copy link
Contributor

@TomStrepsil TomStrepsil commented Feb 7, 2025

Issue

resolves #20

Details

This PR fixes the issue whereby the ?showExperiments querystring handling in the NextJs example is ineffective.

Originally, the NextJs example demonstrated the ssr package, despite this package being superfluous for a platform that has native props-serialization. When an opportunity arose to demonstrate the ssr package elsewhere (made in v0.2.0), the NextJs example was moved to more canonical approach for Next. However, the debug querystring to make the <script type="application/json"> inserted by ssr visible would no longer do anything. This PR fixes that mistake.

Scout Rule:

  • Fix typo is JSDoc comment for webpack package
  • Add README.mds to NPM packages, so npmjs.com doesn't appear empty
  • Tweak the main README.md
  • Move the React 17 note in the features package to the tail of the document, near the react-specific store factories
  • Update React 17 notes to clarify the alias required for react-dom/server, too
  • Update pull_request_template.md to prefix the issue with "resolves " and use hash-shorthand
  • Add homepage to package.jsons, again to link to appropriate package from that field on npmjs.com
  • Fix some links to the packages from the express examples README.md, which had missed a directory level
  • Clarify the need to fork the repository, or get given write access (i.e. ASOS internal), before contributing PRs, as per GitHub documentation:

    If you want to create a new branch for your pull request and do not have write permissions to the repository, you can fork the repository first.

CheckList

  • PR starts with [ISSUE_ID].
  • Has been tested (where required) before merge to main.

TomStrepsil and others added 16 commits December 24, 2024 17:31
* rename to proper module namespace

* update docs links

* update versions

* web toggle point in readme title

* fixup changelog from revised 0.x range

* 2.0.0 -> 0.5.0 in oss version scheme

* fix broken link syntax in CHANGELOG

* consistent quoting

* more version history issues

* fixup module name in jsdoc

* add web
remove sdkInstanceProvider

* remove SDKInstanceProvider

* fixup jsdoc dedupe

* tweak

* clarity re: ssr package

* casing etc
…anged rendering engine? May need a fuzzier match, or a stable ubuntu image
TomStrepsil and others added 5 commits March 4, 2025 10:33
* update workflows

* version

* typo

* update chromium linux snaps

* versions for serve update

* package.json repository field

* update root package.lock

* bugs & directories/doc fields

* fix changelog

---------

Co-authored-by: Tom Pereira <[email protected]>
@TomStrepsil TomStrepsil force-pushed the bug/fix-nextjs-example-show-experiments-query-string-and-update-contributing-guide branch from 0a3eeb6 to a36bc30 Compare April 10, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the "showExperiments" flag in the "examples/next" fixtures.. which currently does nothing.
1 participant