Skip to content

[REFACTOR/#51] rest uri naming conventions / application test / firebase 반영 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eeeeeaaan merged 12 commits into from
Sep 2, 2025
Merged

[REFACTOR/#51] rest uri naming conventions / application test / firebase 반영 #54

eeeeeaaan merged 12 commits into from
Sep 2, 2025

Conversation

@2ghrms
Copy link
Member

@2ghrms 2ghrms commented Sep 2, 2025 •
edited
Loading

#️⃣연관된 이슈

close #51

📝작업 내용

작업한 내용을 작성해주세요.

🔎코드 설명(스크린샷(선택))

코드에 대한 설명을 작성해주세요.

  • Auth API의 컨트롤러에서 naming convention에 맞게 수정함
  • Auth API의 컨트롤러에서 versioning convention에 맞게 수정함
  • 향후 Test 코드를 작성할 것에 대비해서 CI에서 context load를 테스트하도록 함
  • firebase의 service-account.json을 배포하도록 함. docker-compose.yml에서 마운팅하는 경로를 추가함

💬고민사항 및 리뷰 요구사항 (Optional)

고민사항 및 의견 받고 싶은 부분 있으면 적어두기

비고 (Optional)

참고했던 링크 등 참고 사항을 적어주세요. 코드 리뷰하는 사람이 참고해야 하는 내용을 자유로운 형식으로 적을 수 있습니다.

@2ghrms 2ghrms self-assigned this Sep 2, 2025
@2ghrms 2ghrms added the ♻️ refactor Refactor code label Sep 2, 2025
@2ghrms 2ghrms linked an issue Sep 2, 2025 that may be closed by this pull request
[REFACTOR] Auth REST URI Naming Conventions 및 application-test.yml 및 secrets 반영 #51
Closed
4 tasks
@2ghrms 2ghrms changed the base branch from main to develop September 2, 2025 09:19
2ghrms added 10 commits September 2, 2025 18:21
@BAEK0111 BAEK0111 self-requested a review September 2, 2025 21:18
BAEK0111
BAEK0111 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@BAEK0111 BAEK0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다!!!!!!

@leesumin0526 leesumin0526 self-requested a review September 2, 2025 21:46
leesumin0526
leesumin0526 approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@leesumin0526 leesumin0526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@eeeeeaaan eeeeeaaan merged commit 54c6ae4 into develop Sep 2, 2025
1 check passed
@2ghrms 2ghrms deleted the refactor/#51-rest-uri-naming-conventions-application-test branch September 3, 2025 06:59
@2ghrms 2ghrms changed the title [Refactor/#51] rest uri naming conventions / application test / firebase 반영 [REFACTOR/#51] rest uri naming conventions / application test / firebase 반영 Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leesumin0526 leesumin0526 leesumin0526 approved these changes

@BAEK0111 BAEK0111 BAEK0111 approved these changes

Assignees

@2ghrms 2ghrms

Labels

♻️ refactor Refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[REFACTOR] Auth REST URI Naming Conventions 및 application-test.yml 및 secrets 반영

5 participants

@2ghrms @leesumin0526 @BAEK0111 @eeeeeaaan