Skip to content

Conversation

mpadge
Copy link
Member

@mpadge mpadge commented Dec 16, 2019

Just involved checking the input$layer setting on every operation. Should hopefully be good to go.

@mpadge mpadge requested a review from Robinlovelace December 16, 2019 19:37
@Robinlovelace
Copy link
Member

Thanks @mpadge will test now. Great work by the looks of it.

@Robinlovelace
Copy link
Member

I get this error message @mpadge:

 runUpthat()
Loading required package: shiny

Listening on http://127.0.0.1:7112
Found these Rds files: ./net-accra.Rds, ./net-bristol.Rds, ./net-kathmandu.Rds, inst/net-ac1.Rds
Reading this matching file: ./net-accra.Rds
Warning: Error in if: argument is of length zero
  [No stack trace available]
Warning: Error in if: argument is of length zero
  [No stack trace available]

@Robinlovelace
Copy link
Member

But also get that on the master branch...

@Robinlovelace
Copy link
Member

Robinlovelace commented Dec 17, 2019

The error seems to be due to something like this:

a = NULL
if(a == 7) {print("a")}
Error in if (a == 7) { : argument is of length zero

@Robinlovelace
Copy link
Member

Putting on pause until I can debug the crashes on master... Any ideas @mpadge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants