Align snapshot bulk actions with Foreman bulk actions #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EnigmaXV
commented
Dec 31, 2025
EnigmaXV
commented
- Align snapshot bulk actions with the existing Foreman bulk action style and behavior.
- Improve error toast messaging by:
- Including a direct link to the list of failed hosts.
- Removing the misleading “check production logs” message.
- Update and adjust controller and frontend tests to reflect the new bulk action behavior and API changes
EnigmaXV
force-pushed
the
align_snapshot_bulkactions_with_foreman
branch
7 times, most recently
from
c3f93f0 to
d7bd43d
Compare
EnigmaXV
force-pushed
the
align_snapshot_bulkactions_with_foreman
branch
2 times, most recently
from
b71810d to
c4ffbd7
Compare
Contributor
nadjaheitmann
left a comment
nadjaheitmann
left a comment
There was a problem hiding this comment.
While testing, I realized that there is no form update triggered on the 'Host details' page anymore. I think that this is already broken since the last patch and we should fix it here as it is a regression.
app/models/foreman_snapshot_management/extensions/bulk_hosts_manager.rb
Outdated
Show resolved
Hide resolved
app/models/foreman_snapshot_management/extensions/bulk_hosts_manager.rb
Outdated
Show resolved
Hide resolved
EnigmaXV
force-pushed
the
align_snapshot_bulkactions_with_foreman
branch
from
c4ffbd7 to
fe7cb32
Compare
EnigmaXV
force-pushed
the
align_snapshot_bulkactions_with_foreman
branch
from
fe7cb32 to
9c1e785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.