NEW: add getdiscount method in API #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- retrieves discount rate and discounted price for product-company combination - fix DiscountRule::fetchByCrit() method to allow correct treatment if all arguments are not provided
altairis-noe
force-pushed
the
api_discountval
branch
from
7ece192 to
fcd88b3
Compare
altairis-noe
force-pushed
the
api_discountval
branch
from
fb7a3ef to
593744e
Compare
Author
|
In addition I completed the _cleanObjectDatas() method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues what I began in #125, and adds the possibility to get discount rate and discounted subprice from product and thirdarty ID.
I took the liberty to complement the DiscountRule::fetchByCrit() method in order to allow an answer with empty parameters.
Hope you will like it.