Fix/151/sentry/module related #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- permissions not checked - disabled modules included This fix isn't perfect: for third parties, permission should be checked on an individual basis (is the current user allowed to see this third party), not globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gros fix car je ne fix pas uniquement le warning Sentry, mais également des erreurs de conception dont une petite faille de sécu (défaut de vérification des permissions dans le backend ajax).
Le js a été déplacé vers un fichier tout neuf (comme discuté en réu dev), puis refactorisé pour résoudre le warning, réduire la dépendance jQuery et clarifier le code.
Le backend (interface.php) a été en partie réécrit pour: