Skip to content

Conversation

@MUSKANNISHAD
Copy link
Contributor

๐Ÿ“Œ Pull Request Summary

Implemented unified login flow with proper session handling and environment configuration.

๐Ÿ› ๏ธ Type of Change

  • Added a SuccessPopup for a cleaner login/signup experience.

  • Fixed auth state conflicts: replaced localStorage usage in frontend with HTTP-only cookies from backend.

  • Added .env.example as a template for environment variables to standardize setup across devs.- [ ] ๐Ÿ› Bug fix

  • [โœ…] โœจ New feature
  • [โœ…] ๐Ÿงน Code refactor
  • [โœ… ] ๐Ÿ“„ Documentation update

๐Ÿ”— Related Issue

Closes #784

โœ… Checklist

Please confirm the following before submitting:

  • [โœ…] I have tested my changes locally
  • [โœ…] I have run npm run dev or similar to check code style
  • [โœ…] I have updated documentation (if necessary)
  • [โœ…] My code follows the projectโ€™s coding conventions
  • [โœ…] I have merged the latest main or dev branch
  • [โœ…] I have performed a self-review of my own code.
  • [โœ…] My changes generate no new warnings or errors.
  • [โœ…] I have commented my code, especially in hard-to-understand areas
  • [โœ…] I have linked the related issue

๐Ÿ“ธ Screenshots (if applicable)

before=>
image

After=>
Screenshot (809)
Screenshot (807)

๐Ÿง  Additional Notes

  • Anything else you want the reviewer to know.
  • Frontend now relies on backend cookies for auth state.

  • .env.example helps new developers quickly configure environment variables without exposing secrets.

@vercel
Copy link

vercel bot commented Oct 18, 2025

@MUSKANNISHAD is attempting to deploy a commit to the Abhi's projects Team on Vercel.

A member of the Team first needs to authorize it.

@MUSKANNISHAD
Copy link
Contributor Author

Iโ€™ve reviewed the changes in this PR and verified that everything looks good. Authorized the deployment from the fork for preview purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

๐Ÿ› : Signup and Login Not Functioning Properly

1 participant