Skip to content

Fix iridas cube parser to accept and convert double precision. #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix iridas cube parser to accept and convert double precision. #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/OpenColorIO/fileformats/FileFormatIridasCube.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,12 @@ LocalFileFormat::read(std::istream & istream,
}
else
{
float r = NAN;
float g = NAN;
float b = NAN;
// Use doubles here as some iridas cube files may be written with double precision
// string values, and these will raise result_out_of_range errors in NumberUtils::from_chars
// instead of silently converting to float like they used to
double r = NAN;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably needs an explicit cast to double to make the Windows checks happy?

double g = NAN;
double b = NAN;

const auto rAnswer = NumberUtils::from_chars(valR, valR + 64, r);
const auto gAnswer = NumberUtils::from_chars(valG, valG + 64, g);
Expand Down
Loading